stacklok / toolhive / 21284416549

60%

Build Type

push

github

Committed by web-flow

Commit Message

Fix authorization bypass for unknown MCP methods (#3406)

Previously, MCP methods not in the MCPMethodToFeatureOperation map
bypassed authorization checks entirely, allowing unauthenticated access
to security-sensitive operations like sampling/createMessage (LLM text
generation), elicitation/create, and task management methods.

This commit switches to a default-deny security model where:
  - Unknown methods are rejected with a clear error message
  - All methods must be explicitly configured in the authorization map
  - Protocol-level methods (ping, initialize, notifications) are
    explicitly marked as always-allowed
  - Security-sensitive methods are explicitly denied until proper
    authorization features are implemented

Closes: #3168

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Run Details

7 of 7 new or added lines in 1 file covered. (100.0%)

5 existing lines in 2 files now uncovered.

36977 of 61781 relevant lines covered (59.85%)

80.0 hits per line