yext / answers-hitchhiker-theme / 21253221135

9%

master: 9%

push

github

Merge master (v1.36.1) into develop (#1243)

* chore: remove clientId functionality from GoogleMaps (#1238)

Client Ids are being deprecated for Google Maps
https://developers.google.com/maps/premium/migrate-client-id

To avoid this issue, remove the logic which reads in and
uses clientIds. Luckily, apiKeys were already supported here,
and we even have logic to provide a default apiKey if one
is not specified in the config.

J=WAT-5114
TEST=manual

ran test site and google map loaded

* fix: have GDA card jambo command update index page template (#1239)

Updates the logic for the generativedirectanswercard jambo command to update pages/index.html.hbs to ensure that the `{{> generativedirectanswercards/all }}` line is present under the `{{#> script/core }}` tag.

J=WAT-5327
TEST=manual

Ran command from test-site directory. Tested the following scenarios:
1. pages/index.html.hbs already has uncommented partial --> file left unchanged
2. pages/index.html.hbs has partial commented out --> partial is uncommented
3. pages/index.html.hbs has no GDA partial, has {{> directanswercards/all }} partial --> GDA partial is inserted beneath {{> directanswercards/all }}
4. pages/index.html.hbs has no GDA or regular DA partial, has {{> cards/all }} partial --> GDA partial is inserted beneath {{> cards/all }}
5. pages/index.html.hbs has no GDA, DA, or card partial, has {{#> script/core }} --> GDA partial is inserted beneath {{#> script/core }}
6. pages/index.html.hbs has no {{#> script/core }} --> warning is logged, file left unchanged

* Version 1.36.1

* fix: have GDA card jambo command update index page template (#1239)
* chore: remove clientId functionality from GoogleMaps (#1238)

---------

Co-authored-by: Fondryext <160865254+Fondryext@users.noreply.github.com>
Co-authored-by: mkouzel-yext <mkouzel@yext.com>

283 of 3137 branches covered (9.02%)

Branch coverage included in aggregate %.

0 of 3 new or added lines in 2 files covered. (0.0%)

504 of 5554 relevant lines covered (9.07%)

0.92 hits per line