Mellanox / sriov-network-operator / 21246933371

63%

master: 63%

Build Type

push

github

Committed by e0ne

Commit Message

fix: getCurrentBridgeState to return all uplinks for grouped bridges

The getCurrentBridgeState() function was only processing the first
uplink (Uplinks[0]) and ignoring the rest. This caused bridges with
multiple uplinks (created via groupingPolicy: all) to constantly
reconfigure because the current state comparison always showed a
mismatch.

Additionally, NeedToUpdateBridges was comparing the entire Bridges
struct including the GroupingPolicy field. However, GroupingPolicy is
a policy directive used during configuration and is not stored in OVS,
so it will never appear in the discovered status. This caused another
source of constant mismatch detection.

Changes:
- Modify getCurrentBridgeState() to iterate through all uplinks in
  knownConfig.Uplinks instead of only processing the first one
- Modify NeedToUpdateBridges to only compare OVS configurations,
  ignoring the GroupingPolicy field
- Add test cases for bridge with multiple uplinks
- Add test case for partial uplinks when some interfaces are missing
- Add test case for groupingPolicy difference being ignored

Fixes infinite reconciliation loop where bridge ports kept being
removed and re-added on every sync cycle.

Signed-off-by: Alexander Maslennikov <amaslennikov@nvidia.com>
(cherry picked from commit c1c988791)

Run Details

32 of 40 new or added lines in 2 files covered. (80.0%)

813 existing lines in 6 files now uncovered.

9396 of 14926 relevant lines covered (62.95%)

0.7 hits per line