yext / search-ui-react / 21227444954

85%

main: 85%

Pull #617

github

fix: unmount pin components asynchronously

During a MapboxMap component update, the PinComponents are removed using a root.unmount() call and then rebuilt. The unmount, however, cannot happen while a render is in progress: previously, React would throw a warning and defer the actual unmount until the current render finished, but this change makes the deferral explicit. The MapboxMap render happens (during which the new PinComponents are built), and then the old PinComponents are destroyed.

J=WAT-5325
TEST=manual

Built and ran test-site. Confirmed that the "Attempted to synchronously unmount a root" error was no longer thrown.

1003 of 1395 branches covered (71.9%)

Branch coverage included in aggregate %.

5 of 5 new or added lines in 1 file covered. (100.0%)

2251 of 2426 relevant lines covered (92.79%)

149.25 hits per line