bombsimon / wsl / 21226264594

94%

Build Type

push

github

Committed by web-flow

Commit Message

Add support for `newline-after-block` (#221)

* Add support for `newline-after-block`

This adds a new check type to enforce newline after any block (closing
`}`). In addition, it also makes the check for empty line while using
`case-max-lines` a bit more strict by now _not_ counting a trailing
comment as an empty line.

While doing this, there's a new column based logic to figure out where
the newline should go in the end of a case. If it's aligned with the
last statement of the case body the line is inserted after. If it's
aligned with then next case arm, the line is inserted before the
comment.

While working on this we're also moving to a line based check that uses
`LineStart` to make replacements and with that simplifying some comment
parsing since we only need to know the pos where the line starts. This
also allowed to add support to fix removal of whitespaces both before
_and_ after leading comments in blocks.

* Use `ast.Pos` when checking comments

We don't need to check line number to find relevant comments, if we
instead use the `ast.Pos` as long as possible we save a ton of
conversions and gets some speed improvement.

* Make `isErrNotNilCheck` check stmt type

Removes extra check for statement type before calling function.

Also adds a more detailed comment to why we skip complex groups.

* Don't create `CommentMap` for file

* Improve trailing case comments handling

* Add support to remove newline after left-aligned comment

Similar to how we do support trailing comments in a block, but no
newline after the comment, we want to support left-aligned comments in
case bodies but keep them flush against the next case.

* Improve method name

* Use constant instead of magic number

* Improve finding comments after blocks

* Consider comments when checking case total lines

* Remove more `NewCommentMap` calls

* Skip `FuncLit` for newline after block

Run Details

273 of 285 new or added lines in 2 files covered. (95.79%)

2 existing lines in 1 file now uncovered.

1434 of 1549 relevant lines covered (92.58%)

229.82 hits per line