bitcoindevkit / bdk / 21224262458

79%

push

github

Merge bitcoindevkit/bdk#2099: Fix no-std compilation

<a class=hub.com/bitcoindevkit/bdk/commit/<a class="double-link" href="https://git"><a class=hub.com/bitcoindevkit/bdk/commit/546b07e23b6219693976d7a4eeaacdc7c304f04a">546b07e23 chore(example_cli,esplora): Fix no-std compilation (志宇)

Pull request description:

  ### Description

  `serde_json` requires either `std` or `alloc` feature enabled. We just enable `alloc` as we don't need the features that `std` provides.

  ### Notes to the reviewers

  `alloc` is just a subset of `std`. `json_serde` has `from_reader()` & `to_writer()` methods if `std` is enabled. We aren't using those methods so just having `alloc` is fine.

  I'm also not sure why an explicit `alloc` cargo feature flag is needed in `serde_json`. They can just have an internal prelude based on whether the `std` feature is enabled.

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

ACKs for top commit:
  luisschwab:
    ACK 546b07e23b6219693976d7a4eeaacdc7c304f04a
  oleonardolima:
    ACK 546b07e23b6219693976d7a4eeaacdc7c304f04a

Tree-SHA512: 05afc4d7ee83604627c4cffc8d4639f39c2

378 of 512 branches covered (73.83%)

Branch coverage included in aggregate %.

4236 of 5334 relevant lines covered (79.42%)

3077.88 hits per line