gnosisguild / zodiac-modifier-roles / 21221542173

93%

main: 96%

Pull #393

github

Decouple packing from storing, optimize load  (#429)

* refactor(evm): optimize condition serialization with linear-pass topology

Refactors the condition tree processing pipeline to use a single O(N) backward pass for topology analysis, replacing redundant recursive traversals.

* refactor(evm): eliminate Layout tree by computing layout directly from topology

* add layout.spec.ts for full pipeline layout assertions

* refactor(evm): remove TypeTree library, inline encoding resolution in Integrity

* rename structural and offset flags in Topology

* Simplify Topology struct and optimize resolution logic

* Large condition test was breaking the coverage tooling

* Simplify hasCompValue check to use compValue.length directly

* prune non-first children of non-variant logical nodes from layout

* replace BFS queue with linear forward pass for layout packing

* rename _pruneUnreachable to _excludeFromLayout

* simplify _excludeFromLayout to single-purpose subtree exclusion

* clean up TopologyLib documentation

* improve Topology comments and tighten typeHash calculation

* prettier

* Extract condition to local variable in ConditionTransform

* Shave 30% off ConditionPacking costs: optimizemload/or/mstore for node and compValue Condition writes

* Shave 12% of Layout packing:  inline _packLayoutNode and use assembly for node writes

* Merge _validateRoot into _validateBFS for single-pass validation

* Optimize typeHash computation using scratch space assembly

* rename maxPluckIndex to maxPluckCount

* Refactor allowTarget/allowFunction to accept pre-packed condition buffers

* Fix test failures after allowTarget/allowFunction refactor

* Unify condition packing format with single-pass unpacking

* Inline _shallowCopy in ConditionUnpacker to reduce call overhead

* Fold ConditionTransform into ConditionPacker

* Add big condition test case

* Tighten structural detection and isInLayout for logical nodes

* Add typeHash to Topology struct, use naive loop... (continued)

543 of 584 branches covered (92.98%)

Branch coverage included in aggregate %.

948 of 1021 relevant lines covered (92.85%)

284.58 hits per line