safe-global / safe-client-gateway / 21212314323

88%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(zerion): improve ZerionChainMappingService with Symbol DI and optimized caching (#2869)

* refactor(zerion): add interface, Symbol DI, and optimize cache for chain mapping

Refactor ZerionChainMappingService with several improvements:

Interface and Dependency Injection:
- Export IZerionChainMappingService interface with JSDoc documentation
- Export Symbol for dependency injection token
- Update module to provide service via Symbol
- Rename methods to getNetworkNameFromChainId/getChainIdFromNetworkName

Cache Optimization:
- Combine both mapping directions (chainIdToName, nameToChainId) into
  a single cache entry, reducing from 4 keys to 2 (mainnet + testnet)
- Simplify getZerionChainsCacheDir() by removing direction parameter
- Make cache TTL configurable via ZERION_CHAINS_CACHE_TTL_SECONDS
  (defaults to 86400 seconds / 24 hours)

Error Handling:
- Return null instead of undefined for not-found cases
- Log errors when chain fetch fails, return empty mappings gracefully

This follows codebase patterns for Symbol-based injection and provides
a cleaner API for consumers.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(balances): use ZerionChainMappingService via Symbol injection

Update zerion-balances-api to use the refactored chain mapping service:

- Inject IZerionChainMappingService via Symbol
- Import ZerionModule in BalancesModule
- Return empty array when chain is not supported (graceful handling)
- Add debug logging when skipping balances for unsupported chains

Previously, unsupported chains could cause errors. Now the service
gracefully returns an empty result with appropriate logging, making
it easier to diagnose chain support issues.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor(zerion): use ZerionChainMappingService in positions and portfolio

Apply the same refactoring pattern to remaining Zerion API consumers:

- Inject IZerionChainMappingService via Symbol in both services
- Skip pos... (continued)

Coverage Stats

3006 of 3704 branches covered (81.16%)

Branch coverage included in aggregate %.

50 of 53 new or added lines in 7 files covered. (94.34%)

69 existing lines in 4 files now uncovered.

14021 of 15259 relevant lines covered (91.89%)

592.22 hits per line