NVIDIA / holodeck / 21212106071

44%

main: 44%

push

github

fix: audit fixes for heterogeneous cluster support

Address issues identified during code audit:

P0 - Fix resolveImageForNode() state mutation bug:
  - Extract findLegacyAMI() as pure function that doesn't mutate state
  - Update resolveImageForNode() to use findLegacyAMI() for legacy fallback
  - Refactor setLegacyAMI() to use findLegacyAMI() (reduces duplication)

P1 - Add unit tests for resolveImageForNode():
  - 13 test cases covering all code paths
  - Regression test for P0 fix (DoesNotMutateState)
  - Tests for findLegacyAMI() function

P2 - SSH username handling for heterogeneous clusters:
  - Add SSHUsername field to NodeStatus (API)
  - Add SSHUsername field to InstanceInfo (AWS provider)
  - Add SSHUsername field to NodeInfo (provisioner)
  - Add getUsernameForNode() helper with fallback to global username
  - Update all SSH connection points to use per-node username

P3 - Parameterize Amazon Linux Fedora version mapping:
  - Add get_amzn_fedora_version() function to common.go
  - Map AL2023->F39, AL2024->F40, AL2->F35
  - Update containerd template to use HOLODECK_AMZN_FEDORA_VERSION
  - Add CommonFunctions tests

Additional:
  - Fix deprecated GinkgoParallelNode() -> GinkgoParallelProcess()
  - Add common_test.go for CommonFunctions validation

Ref: #568
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

22 of 50 new or added lines in 3 files covered. (44.0%)

1967 of 4452 relevant lines covered (44.18%)

0.49 hits per line