kubevirt / containerized-data-importer / #5783
49%
main: 49%

LAST BUILD BRANCH: provisioner-aware-vsc-selection-for-dic
DEFAULT BRANCH: main
Ran
Jobs 1
Files 157
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 49.456% (+0.02%) from 49.439%
#5783

Pull #3991

travis-ci

noamasu 
Add provisioner-aware DataImportCron configuration via StorageProfile annotations

Add support for provisioner-specific requirements when creating snapshots
and PVCs for DataImportCron. Some provisioners have specific needs:

- GKE Persistent Disk requires snapshot-type: images parameter in VSC
- GKE Persistent Disk and Rook Ceph RBD require RWO access mode for DataImportCron PVCs

Change details:
- Add StorageProfile annotations for DataImportCron configuration:
    cdi.kubevirt.io/useReadWriteOnceForDataImportCron: Signals RWO access mode
    cdi.kubevirt.io/snapshotClassForDataImportCron: Specifies VSC name
- Centralize provisioner-specific configuration in storagecapabilities:
    UseReadWriteOnceForDataImportCronByProvisionerKey: Maps provisioners requiring RWO
    SnapshotClassParametersForDataImportCronByProvisionerKey: Maps provisioners to VSC parameters
- StorageProfile controller automatically reconciles annotations based on provisioner
- DataImportCron controller applies RWO from StorageProfile when DV doesn't specify access modes
- DataImportCron controller selects VSC with priority: StorageProfile annotation > StorageProfile status > standard selection
- Unit tests for both controllers
- Update documentation with annotation details

Signed-off-by: Noam Assouline <nassouli@redhat.com>
Pull Request #3991: Add provisioner-aware VolumeSnapshotClass selection and RWO access mode for DataImportCron

82 of 147 new or added lines in 3 files covered. (55.78%)

2 existing lines in 1 file now uncovered.

14689 of 29701 relevant lines covered (49.46%)

0.55 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
11
68.61
 1.19% pkg/controller/storageprofile-controller.go
26
65.5
 -0.18% pkg/controller/dataimportcron-controller.go
28
0.0
 0.0% pkg/storagecapabilities/storagecapabilities.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
62.42
 -0.26% pkg/importer/vddk-datasource_amd64.go
Jobs
ID Job ID Ran Files Coverage
1 #5783.1 157
49.46
Source Files on build #5783