Alan-Jowett / CoPilot-For-Consensus / 21183347829

77%

push

github

Fix RabbitMQ subscriber channel closure causing permanent pipeline stalls (#986)

* Initial plan

* Add reconnection logic to RabbitMQ subscriber and health check for embedding service

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add subscriber thread health monitoring to all services

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add comprehensive unit tests for RabbitMQ subscriber reconnection

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback: make max delay configurable and add shutdown flag

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix subscriber loop and health checks

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Fix typing guards in subscriber

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address PR review feedback: fix exclusive queues, backoff cooldown, AssertionError reconnection, and enhance test

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix test timeout for transport assertion error handling

The test was timing out because after commit 8bf149b, AssertionError handling was changed to reset state and continue the reconnection loop instead of returning. This caused the test to loop infinitely.

Fixed by:
- Mock _reconnect() to return False, making the loop exit
- Add side effect function that sets _shutdown_requested on second call
- This allows the test to verify the error handling while preventing infinite loops

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address PR review: use flag for exclusive queues, enforce full cooldown, simplify test

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: ... (continued)

110 of 167 new or added lines in 1 file covered. (65.87%)

8261 of 10731 relevant lines covered (76.98%)

0.87 hits per line