thewca / worldcubeassociation.org / 21174478748

77%

Build Type

push

github

Committed by web-flow

Commit Message

Use Attempts instead of value1-5 when displaying results (#12531)

* fix solve_tds_for_result with new attempts

* rubocop

* create attempts in results

* switch to after(:create) to create the attempts

* don't create result for inbox results

* correctly set result_attempts after build in tests

* always use 5 tds

* special case for InboxResult

* use result_attempts in live results

* fix result_with_n_solves

* use result_attempts_payload

* fix solved_times tests with skipped values

* Make Cutoff Validator work with attempts

* change solve_times in inboxresults so it works with new validator

* rubocop

* fix one test by reloading

* Update resultable after merge

* rubocop

* add includes for displaying competition results

* Update app/helpers/results_helper.rb

Co-authored-by: Gregor Billing <gregor.billing.dev@gmail.com>

* Update app/jobs/add_live_result_job.rb

Co-authored-by: Gregor Billing <gregor.billing.dev@gmail.com>

* Update app/controllers/live_controller.rb

Co-authored-by: Gregor Billing <gregor.billing.dev@gmail.com>

* review changes

* reload after updating result_attempts

* Run attempt upsert after create and update

* Add memory backfilling PoC to Result model

* Update update calls in IRV test cases

* Fix memory binding target assignment

* Make sure the parent result is coupled in-memory

* Be more strict about post-validation reloading

* Clean up validations in result_attempt

* Simplify result_with_n_solves test fixture

* Remove redundant double-initializer in test data

* Rework Resultable methods hierarchy

* Unroll changes to IRV and tests

* Steal SQL queries for records from #12696

* Replace usage of valueN in Person model

* Add useful indices for records and rankings queries

* Unroll change to ResultsHelper with attempts filling

* Replace implicit joins by explicit joins in records queries

* Fix whoopsie in solve time constructor

* Join result_attempts into records query

* Use updated details in old W... (continued)

Run Details

40 of 47 new or added lines in 12 files covered. (85.11%)

2 existing lines in 1 file now uncovered.

9903 of 12920 relevant lines covered (76.65%)

3460.57 hits per line