pywbem / pywbemtools / test-2774

93%

Build Type

push

github

Committed by web-flow

Commit Message

Fixed start program timeouts in listener tests; Enabled tests again (#1501)

Details:

* Fixed the timeouts of the start program when the unit tests set up
  listeners. The issue were stdout/stderr file handles being inherited
  from the start program into the run program.

  This required some redesigns:

  - Instead of using pipes between the test process and the start
    command process, the start command now supports hidden options
    --stdout-file and --stderr-file that capture stdout/stderr into
    temporary files. That approach is only used for the start command,
    because only that command starts another command (the run command).
    That caused changes in check_output() when running the pywbemlistener
    command, and changes in the start command to handle the new options.

  - This also required changes in the handling of the --logdir option
    in the run command. The approach with using dup2() on Linux/macOS
    was replaced by simply setting sys.stdout/stderr to the log
    file stream, or by leaving it unchanged when no long file was
    specified. The latter change now displays messages that were
    previously dropped, when verbose mode is used and logging is not
    used.

  - When the run command fails by raising a ClickException and the
    listener thread (in the WBEMListener class) was already started,
    the run command could not terminate and was hung until the
    start command sent a TERM signal after timing out. That caused the
    TERM signal handler in the run command to raise SystemExit, but
    because the run program was already in the process of terminating,
    Python displays a "Ignoring exception ..." warning. That was
    resolved by stopping the listener thread before raising exceptions
    in the run command. Added a new function stop_listener_thread()
    for that.

* Needed pywbem PRs 3359 and 3364 to fix other hangs leading to timeuts
  during start and sometimes stop. These PRs will be released in pywbe... (continued)

Run Details

90 of 96 new or added lines in 3 files covered. (93.75%)

2 existing lines in 1 file now uncovered.

6139 of 6606 relevant lines covered (92.93%)

10.03 hits per line