• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

stacklok / toolhive / 21134104714
59%

Build:
DEFAULT BRANCH: main
Ran 19 Jan 2026 10:38AM UTC
Jobs 1
Files 447
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

19 Jan 2026 10:31AM UTC coverage: 59.15% (+0.03%) from 59.116%
21134104714

push

github

web-flow
Fix keyctl password not re-prompted after incorrect entry (#3334)

When a user mistypes their keyctl password on first invocation after
reboot, all subsequent ToolHive invocations would fail with
"cipher: message authentication failed" until reboot or manual reset.

Root cause: Password was stored in keyring before validating it could
decrypt the secrets file.

This fix implements:
- Two-phase password storage: GetSecretsPassword() now returns
  (password, isNew, error) and password is only stored after
  successful decryption validation via new StoreSecretsPassword()
- Fix deadlock in keyctl DeleteAll by extracting deleteKeyUnlocked()
- Fix cross-process deletion by searching kernel keyring directly
  instead of relying on in-memory map

Fixes #3332

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

17 of 46 new or added lines in 3 files covered. (36.96%)

7 existing lines in 3 files now uncovered.

35380 of 59814 relevant lines covered (59.15%)

82.1 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
4
81.13
26.4% pkg/secrets/keyring/keyctl_linux.go
4
53.6
-0.16% pkg/workloads/manager.go
21
32.88
-0.93% pkg/secrets/factory.go

Uncovered Existing Lines

Lines Coverage ∆ File
2
81.13
26.4% pkg/secrets/keyring/keyctl_linux.go
2
84.23
-0.28% pkg/vmcp/composer/workflow_engine.go
3
71.85
-1.11% pkg/ignore/processor.go
Jobs
ID Job ID Ran Files Coverage
1 21134104714.1 19 Jan 2026 10:38AM UTC 447
59.15
GitHub Action Run
Source Files on build 21134104714
  • Tree
  • List 447
  • Changed 8
  • Source Changed 5
  • Coverage Changed 7
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Github Actions Build #21134104714
  • a24d383c on github
  • Prev Build on main (#21094488905)
  • Next Build on main (#21134477010)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc