kaidokert / xacro / 21130744273

89%

main: 94%

Pull #75

github

Address PR review feedback: performance, testing, and documentation

1. Performance: Avoid double-cloning children in expand_macro_call
   - Use core::mem::take to move children instead of clone-then-replace
   - Eliminates extra allocation on every macro call

2. Testing: Check specific error in test_if_around_block_parameter_false
   - Verify panic message contains 'Missing block parameter'
   - Prevents false positives from unrelated panics

3. Testing: Add test_lazy_block_with_conditionals_disabled
   - Covers False case for lazy blocks with conditionals
   - Tests that item 2 is not present when condition is False

4. Documentation: Remove brittle Python line number references
   - Replace with behavioral description
   - More maintainable as Python implementation evolves

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

27 of 28 new or added lines in 2 files covered. (96.43%)

4886 of 5484 relevant lines covered (89.1%)

260.95 hits per line