babelfish-for-postgresql / babelfish_extensions / 21112201805

76%

BABEL_5_X_DEV: 77%

push

github

Fix: Crash when dropping table variable related temp tables due to being in PG dialect (#4410) (#4456)

In BABEL-6227, nested calls corrupted the dialect to 'postgres' causing
table variable temp table cleanup to fail. In BABEL-6239, nested calls left
the dialect as 'postgres' causing subsequent TSQL queries to be parsed
with the wrong parser.

This is because of using both direct assignment and set_config_option()
function together in a nested call stack. The set_config_option() function
is PGs GUC setting infrastructure which internally maintains a prev value
stack. This does not work well, if caller functions have used direct
assignment instead because it would mean that the value does not get
registered in the internal GUC stack, leading to restoration of incorrect
value for sql_dialect.

The fix for this is to use direct assignment in the culprit function which
is using set_config_option. Previously, we've made the decision to use
direct assignment instead of set_config because of perf related issues.

Task - BABEL-6227 & BABEL-6239


(cherry picked from commit 67248ef01)

Signed-off-by: Ayush Shah <ayushdsh@amazon.com>

12 of 16 new or added lines in 3 files covered. (75.0%)

50450 of 66427 relevant lines covered (75.95%)

395510.67 hits per line