libKriging / libKriging / 21087646622

63%

push

github

Fix openmp cmake (#312)

* Fix OpenMP find_package error by enabling CXX language

FindOpenMP requires the C, CXX or Fortran languages to be enabled.
Changed LANGUAGES NONE to LANGUAGES CXX in the CMake project definition.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Fix DGELS Parameter 7 error with two-step transpose evaluation

Separate the solve and transpose operations into distinct steps to
ensure full evaluation of each operation. This prevents Armadillo's
lazy evaluation from passing transposed views to LAPACK's DGELS,
which expects contiguous memory with correct leading dimensions.

The issue was that even with intermediate variable assignment,
chaining .solve().t() could still result in expression templates
being passed to DGELS. By splitting into:
1. temp = solve(At, Bt)
2. result = temp.t()

We ensure each operation is fully evaluated before the next.

Fixes: Intel MKL ERROR: Parameter 7 was incorrect on entry to DGELS

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Use arma::trans() instead of .t() to force matrix copies

Replace .t() with arma::trans() throughout rsolve to ensure
actual matrix copies are created rather than transpose views.
The .t() method can return expression templates that delay
evaluation, while arma::trans() is more likely to create
copies, especially when assigned to arma::mat variables.

This should prevent MKL's DGELS from receiving matrices with
incorrect leading dimensions due to transpose views.

Addresses: Intel MKL ERROR: Parameter 7 was incorrect on entry to DGELS

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* Force explicit matrix allocation to fix DGELS Parameter 7 error

Pre-allocate matrices with correct dimensions before assigning
transposed values. This ensures:
1. Memory is contiguous and properly al... (continued)

9 of 9 new or added lines in 2 files covered. (100.0%)

8614 of 13641 relevant lines covered (63.15%)

78026.21 hits per line