wboayue / rust-ibapi / 21086366252

87%

Build Type

push

github

Committed by web-flow

Commit Message

fix: prevent scanner infinite hang on error messages (#371)

* fix: prevent scanner infinite hang on error messages (#370)

- Add explicit handling for IncomingMessages::Error in scanner decode
  functions (async and sync) to return Error::Message instead of
  Error::UnexpectedResponse
- Add bounded retry logic (max 10 attempts) to subscription next()
  methods to prevent infinite loops from unexpected responses
- Log warnings on retry attempts and errors when max retries exceeded

Fixes #370

* refactor: extract shared scanner decode function

Move scanner message type matching logic to decode_scanner_message()
in the common decoders module to avoid duplication between async and
sync implementations.

* refactor: extract retry decision logic to common module

Move retry checking and logging to check_retry() function in the
common module. This consolidates the retry decision logic that was
duplicated between async and sync subscription implementations.

- Add RetryDecision enum to represent continue/stop decisions
- Add check_retry() function that handles counting and logging
- Update async and sync subscriptions to use the shared function
- Add test for check_retry()

* style: fix variable naming and format code

Remove underscore prefix from 'err' variable since it is actually used
in the should_retry_error() call.

Run Details

29 of 42 new or added lines in 6 files covered. (69.05%)

4 existing lines in 1 file now uncovered.

8700 of 10037 relevant lines covered (86.68%)

119.08 hits per line