bdwgc / bdwgc / 1990
73%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 37
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 72.953% (+0.01%) from 72.942%
1990

push

travis-ci

ivmai 
Fix race in DllMain by deferring delete_thread call to GC_start_world

PR #831 (bdwgc).

This only matters `GC_win32_dll_threads` mode.

* include/private/gc_priv.h [THREADS && !GC_NO_THREADS_DISCOVERY
&& GC_WIN32_THREADS] (GC_arrays._dll_main_detach_thread_lock): New
field.
* include/private/pthread_support.h [!GC_NO_THREADS_DISCOVERY
&& GC_WIN32_THREADS] (GC_Thread_Rep.pending_delete_thread): Likewise.
* pthread_support.c [!GC_NO_THREADS_DISCOVERY && GC_WIN32_THREADS]
(GC_delete_thread): Update comment.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY] (DETACH_THREAD_LOCK,
DETACH_THREAD_UNLOCK): New macro.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY]
(GC_has_pending_delete_threads): New `static` variable.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY]
(GC_register_my_thread_inner): Add assertion that
`pending_delete_thread` is false.
* win32_threads.c [!MSWINCE] (GC_suspend): Remove code duplication
regarding `GetExitCodeThread()` call.
* win32_threads.c [!MSWINCE && GC_PTHREADS] (GC_suspend): Refine
comment about `pthread_join`.
* win32_threads.c [!MSWINCE && !GC_PTHREADS
&& !GC_NO_THREADS_DISCOVERY] (GC_suspend): Set
`GC_has_pending_delete_threads` and `pending_delete_thread` instead
of `GC_delete_thread()` call; add comment.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY || GC_ASSERTIONS]
(GC_stop_world): Move `GC_please_stop = TRUE` down (to be after setting
of `GC_write_disabled`).
* win32_threads.c [!GC_NO_THREADS_DISCOVERY && !GC_ASSERTIONS]
(GC_stop_world, GC_start_world): Do not set `GC_please_stop` unless
`GC_win32_dll_threads`.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY] (GC_stop_world,
GC_start_world): Wrap setting of `GC_please_stop` into
`DETACH_THREAD_LOCK`/`DETACH_THREAD_UNLOCK`.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY] (GC_stop_world): If
`p->pending_delete_thread`, then do not call `GC_suspend(p)`.
* win32_threads.c [!GC_NO_THREADS_DISCOVERY] (GC_start_world): Define
`pending_delete` local variable; if `GC_has_pending_delete_threads`,
t... (continued)

6479 of 8881 relevant lines covered (72.95%)

13947691.14 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
4
75.91
 -0.85% allchblk.c
4
66.91
 -0.59% finalize.c
5
83.33
 -1.98% mallocx.c
110
76.48
 0.0% pthread_support.c
Jobs
ID Job ID Ran Files Coverage
1 1990.1 37
72.95
 Travis Job
Source Files on build 1990