kubernetes-sigs / karpenter / 21057388274

81%

main: 81%

Build Type

Pull #2800

github

Committed by moko-poi

Commit Message

refactor(utils/node): remove Get prefix from getter functions

Remove "Get" prefix from getter functions in pkg/utils/node to follow
Effective Go and Kubernetes API conventions.

Effective Go states:
"Go doesn't provide automatic support for getters and setters. There's
nothing wrong with providing getters and setters yourself, and it's
often appropriate to do so, but it's neither idiomatic nor necessary
to put Get into the getter's name."

Changes:
- GetPods → Pods
- GetNodeClaims → NodeClaims
- GetCondition → Condition
- GetCurrentlyReschedulablePods → CurrentlyReschedulablePods
- GetProvisionablePods → ProvisionablePods
- GetVolumeAttachments → VolumeAttachments

Updated all usages across 13 files including controllers, state
management, and test utilities.

Ref: https://go.dev/doc/effective_go#Getters
Ref: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-architecture/api-conventions.md

Pull Request Pull Request #2800: refactor(utils/node): Remove Get prefix from getter functions to follow Go conventions

Run Details

20 of 21 new or added lines in 9 files covered. (95.24%)

9 existing lines in 2 files now uncovered.

11976 of 14875 relevant lines covered (80.51%)

70818.83 hits per line