yext / search-ui-react / 21048362989

85%

push

github

fix: update map bounds check to use client values (#614)

This was apparently causing more Invalid LngLat issues in iframes. Now, the map should be correctly sized and taking into account it's actual viewport size.

The map's actual viewport is the canvas client size. canvas.width/height represents the device pixels, which is often larger than the CSS size. canvas.clientWidth/clientHeight uses the CSS pixel size, which is also what fitBounds uses, which is likely why we were running into issues before.

J=WAT-5303
TEST=manual
Packed tarball and saw a test VE site no longer run into the error

1002 of 1391 branches covered (72.03%)

Branch coverage included in aggregate %.

5 of 8 new or added lines in 1 file covered. (62.5%)

2247 of 2422 relevant lines covered (92.77%)

149.47 hits per line