Qiskit / qiskit / 21005190367

88%

Build Type

push

github

Committed by web-flow

Commit Message

Refactor DAGCircuit to use Qubit/Clbit instead of ShareableQubit/ShareableClbit (#15496)

* Refactor DAGCircuit to use Qubit/Clbit instead of ShareableQubit/ShareableClbit

- Modified DAGCircuit::from_circuit and from_circuit_data to accept
  Qubit/Clbit indices instead of ShareableQubit/ShareableClbit
- Updated converters::circuit_to_dag to map shareable bits to local bits
- Modified DAGCircuit::compose to use local bit indices internally
- Updated DAGCircuit::py_compose to handle bit mapping from Python
- Updated C extension (dag.rs) to convert to local bit indices
- Updated disjoint_layout pass to use local bit indices

This improves efficiency and API simplicity for C and Rust callers
as suggested in issue #13456.

Fixes #13456

* Replace ShareableQubit/Clbit with Qubit/Clbit in DAGCircuit functions

- Modified DAGCircuit::from_circuit and from_circuit_data to accept Vec<Qubit>/Vec<Clbit>
- Modified DAGCircuit::compose to accept Qubit/Clbit indices
- Fixed index mapping in dag_compose C binding
- Fixed index mapping in disjoint_layout compose calls

Fixes #15316

* Simplify qk_dag_compose by directly converting u32 to Qubit/Clbit
Removed redundant conversion through ShareableQubit/Clbit as suggested in review.

* Address review feedback: simplify PyValueError usage, apply formatting, and optimize identity_qubit_map
- Simplified PyValueError usage by importing directly instead of qualifying the type
- Applied cargo fmt to modified files as requested
- Optimized identity_qubit_map creation to avoid unnecessary allocation when custom mapping is provided
- Note: identity_clbit_map optimization not applied as the map is used for iteration at line 8130

* Remove identity_clbit_map and generate clbit map inline

- Eliminated redundant identity_clbit_map variable
- Generate identity mapping directly in clbit_map match instead of cloning
- Simplified build_var_mapper by removing is_empty check

As suggested in review.

* Fix formatting in dag.rs

* Fix cli... (continued)

Run Details

129 of 151 new or added lines in 4 files covered. (85.43%)

16 existing lines in 4 files now uncovered.

96971 of 109799 relevant lines covered (88.32%)

1205001.32 hits per line