stacklok / toolhive / 21001866589

59%

Build Type

push

github

Committed by web-flow

Commit Message

Add generic FetchJSON HTTP utility (#3290)

Add type-safe HTTP fetch utilities with functional options pattern for
JSON API requests. Provides FetchJSON for GET requests and
FetchJSONWithForm for POST with form-encoded bodies.

Features:
- Generic type parameter for compile-time type safety
- Automatic Accept header and Content-Type validation
- Response size limiting
- Custom error handlers for domain-specific error parsing
- Secure error messages (uses status text, not response body)

OIDC Discovery:
```go
result, err := networking.FetchJSON[OIDCEndpoints](
    ctx,
    p.httpClient,
    discoveryURL,
    networking.WithErrorHandler(errorHandler),
)
```

OAuth Token Exchange:
```go
result, err := networking.FetchJSONWithForm[tokenResponse](
    ctx,
    p.httpClient,
    endpoint,
    params,
    networking.WithErrorHandler(errorHandler),
)
```

The existing FetchResourceMetadata function in pkg/auth/discovery/discovery.go
has ~60 lines of boilerplate for HTTP/JSON fetching that could be reduced to:

```go
result, err := networking.FetchJSON[auth.RFC9728AuthInfo](ctx, client, metadataURL)
if err != nil {
    return nil, err
}
if result.Data.Resource == "" {
    return nil, fmt.Errorf("metadata missing required 'resource' field")
}
return &result.Data, nil
```

Similar refactoring opportunities exist in:
- pkg/auth/oauth/oidc.go (OIDC discovery)
- pkg/auth/oauth/dynamic_registration.go (DCR responses)

Run Details

77 of 79 new or added lines in 1 file covered. (97.47%)

517 existing lines in 15 files now uncovered.

34515 of 58841 relevant lines covered (58.66%)

81.85 hits per line