NVIDIA / holodeck / 20970742719

36%

main: 54%

push

github

test: improve unit test coverage for CLI commands and cleanup package

This commit extends the test coverage work by adding comprehensive tests for:

CLI Commands:
- cmd/cli/cleanup: 11.8% → 82.4%
  - VPC ID argument validation
  - AWS region resolution (flag, AWS_REGION, AWS_DEFAULT_REGION)
  - Region fallback logic coverage

- cmd/cli/dryrun: 10.0% → 50.0%
  - Before hook error handling (missing/invalid envFile)
  - Unknown provider validation
  - SSH provider key file validation (missing, invalid format)

- cmd/cli/list: 13.8% → 37.9%
  - Non-existent cache directory handling
  - Empty cache directory handling
  - Invalid cache file handling
  - Non-YAML file filtering

- cmd/cli/status: 17.4% → 60.9%
  - Instance ID argument validation
  - Invalid/missing cache file handling

Package Tests:
- pkg/cleanup: 3.4% → 64.7%
  - GetTagValue success/error paths
  - DeleteVPCResources full workflow
  - Error paths for all resource types
  - VPC deletion retry logic

Infrastructure:
- pkg/testutil/mocks/aws.go: Added missing EC2 client methods
  - ModifyNetworkInterfaceAttribute
  - DescribeTags
  - DescribeInternetGateways
  - DescribeInstanceTypes
  - ReplaceRouteTableAssociation

Overall coverage improved from ~32% to 39.3%.

Ref: #571
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

0 of 25 new or added lines in 1 file covered. (0.0%)

1135 of 3119 relevant lines covered (36.39%)

0.41 hits per line