Qiskit / qiskit / 20969635435

88%

Build Type

push

github

Committed by web-flow

Commit Message

Move to rust native errors for rust apis in CircuitData (#15279)

* Move to rust native errors for rust apis in CircuitData

This commit migrates the CircuitData struct to have it's own new error
enum CircuitDataError. This error type encapsulates all the possible
error conditions returned from CircuitData methods and is used directly
in rust. This has two goals, first it enables us to return real error
messages to the C API, and secondly it decouples are rust code from
Python as part of #14240. To enable a build without pyo3 we need to
stop using PyErr in a pure rust context. The idea being that pymethods
will be conditionally compiled and not built, but the other methods that
aren't exposed to python will need to be returning rust error types. One
thing to note is there is at least one method still using a PyResult,
in those cases the methods will be conditionally compiled. Similarly
there is an ErrorFromPython variant in the new CircuitDataError, this
will also be conditionally compiled out, but is necessary because it's
used in places where we are calling python explicitly and need to handle
the error return from that.

Fixes #15027

* Mark error enums as non-exhaustive and document their purpose

This commit adds the non_exhaustive attribute to all the error enums.
While we're using them there is the likelihood we'll add on to them with
new errors as methods are added. This also documents the enums are an
incremental step towards each function owning its error type as part of
the interface. These enums are just the first step towards that by
making it all explicitly defined. Eventually we'll want to split these
off into specific types that are specified per function/method instead
of being bundled together in a single enum.

* PR review of Qiskit/qiskit#15279 (#32)

* Add `thiserror` conversion traits

This uses the `thiserror::Error` derive-macro attributes
`#[error(transparent)]` and `#[from]` to remove boiler plate when
nesting other errors in... (continued)

Run Details

389 of 448 new or added lines in 25 files covered. (86.83%)

31 existing lines in 6 files now uncovered.

96909 of 109731 relevant lines covered (88.32%)

1206322.46 hits per line