stacklok / toolhive / 20965072474

58%

Build Type

push

github

Committed by web-flow

Commit Message

Add OAuth client factory with RFC 8252 loopback support to authserver (#3263)

* Add OAuth client factory with RFC 8252 loopback support to authserver

Add client factory and LoopbackClient for native OAuth clients like
VS Code and Claude Code. Currently the code is unused (but tested!),
when integrated, the authorize handler will use LoopbackClient.

LoopbackClient wraps fosite.DefaultClient to provide RFC 8252 Section
7.3 dynamic port matching for "localhost" hostname. Fosite's built-in
isMatchingAsLoopback uses net.ParseIP().IsLoopback() which only supports
IP addresses (127.0.0.1, ::1), not the "localhost" hostname.

* Clarify hostnamesMatch documentation to note pre-parsed inputs

Add explicit documentation that hostnamesMatch receives pre-parsed
hostname strings from url.Hostname(), not raw URIs. This clarifies
the function's contract and its relationship with matchesAsLoopback.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
Co-authored-by: Don Browne <dmjb@users.noreply.github.com>

Run Details

92 of 100 new or added lines in 1 file covered. (92.0%)

37 existing lines in 5 files now uncovered.

34512 of 59468 relevant lines covered (58.03%)

80.18 hits per line