kubernetes-sigs / karpenter / 20947535802

81%

main: 81%

Build Type

Pull #2778

github

Committed by moko-poi

Commit Message

fix: Allow NodeOverlay with In operator when NodePool uses Exists (#2765)

Previously, when a NodePool used the Exists operator for a custom
label (e.g., nvidia.com/device-plugin.config), and a NodeOverlay
attempted to use the In operator with specific values for the same
label, the compatibility check would fail with "label does not have
known values" error.

This was incorrect behavior because:
- NodePool Exists operator means "this label must exist with any value"
- NodeOverlay In operator means "add resources when label has these values"
- These are logically compatible and should not conflict

This change updates the Compatible() method in requirements.go to
recognize when base requirements use Exists operator and allow
overlay requirements to specify concrete values.

Changes:
- Modified pkg/scheduling/requirements.go Compatible() method
- Added test case in requirements_test.go
- Added integration test in nodeoverlay/suite_test.go for GPU
  time-slicing use case

Fixes #2765

Pull Request Pull Request #2778: fix: NodeOverlay compatibility with NodePool Exists operator

Run Details

2 of 2 new or added lines in 1 file covered. (100.0%)

7 existing lines in 1 file now uncovered.

12010 of 14890 relevant lines covered (80.66%)

120827.56 hits per line