bjmorgan / py-sc-fermi / 20919937437

95%

main: 95%

Build Type

push

github

Committed by bjmorgan

Commit Message

Refactor get_sc_fermi to use scipy.optimize.brentq

Replaced custom bisection-like solver with scipy's Brent's method.

Benefits:
- 40x faster (2.6ms vs 102ms per solve)
- Simpler, more robust code
- Well-tested implementation

The n_trial_steps parameter is deprecated and will be removed in a
future version. Brent's method converges in ~30 iterations.

Also includes fix for charge state concentration scaling (#53) which
was exposed by the new solver's stricter NaN handling.

Closes #52
Closes #53

Run Details

2 of 3 new or added lines in 1 file covered. (66.67%)

13 existing lines in 2 files now uncovered.

516 of 550 relevant lines covered (93.82%)

5.58 hits per line