pywbem / pywbem / test-2982

92%

push

github

Fixed hangs and race conditions in WBEMListener; Added listener logs (#3364)

Details:

* Fixed a hang in WBEMListener.start() that happened for the wildcard host on
  macOS when the IPv6 stack is not properly set up. That is the case on GitHub
  Actions for example. The fix (circumvention) was not to use AF_UNSPEC in
  socket.getaddrinfo(), but to first try AF_INET (IPv4) and only if that fails,
  try AF_INET6 (IPv6).

* Fixed a second hang in in WBEMListener.start() that happened for the wildcard
  host on macOS when the IPv6 stack is not properly set up, that happened in
  the built-in bind_server() method in class http.server.HTTPServer, when it
  attempts to perform a reverse DNS lookup on the IP address. Fixed that by
  special-casing the wildcard IP addresses and setting the host to "localhost"
  in the wildcard case.

* Fixed that in WBEMListener.stop(), the threads were not waited for. This
  can cause race conditions in tests, where the next listener is started
  right after the previous one was stopped, on the same port.

* In test_indicationlistener.py, added a comment to string-typed port numbers
  that they are intentionally string-typed.

* Added debug log messages for resolving the address of listener host.

Signed-off-by: Andreas Maier <andreas.r.maier@gmx.de>

18 of 28 new or added lines in 1 file covered. (64.29%)

11535 of 12484 relevant lines covered (92.4%)

9.22 hits per line