SchSeba / sriov-network-operator-1 / 20901046984

63%

master: 63%

Build Type

push

github

Committed by SchSeba

Commit Message

fix: set correct nadFound=true after NAD creation in updateConditions

After successfully creating a NetworkAttachmentDefinition, the controller
was incorrectly calling updateConditions with nadFound=false, which set
the status to 'waiting for namespace' instead of 'ready'.

This fix:
1. Changes nadFound from false to true after successful NAD creation
2. Changes err to nil (since there's no error on success)
3. Adds a unit test that specifically verifies conditions are set to
   Ready=True immediately after NAD creation

The bug was reported by Gemini code review on PR #1010.

Signed-off-by: Sebastian Sch <sebassch@gmail.com>

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

6 existing lines in 3 files now uncovered.

9416 of 14800 relevant lines covered (63.62%)

0.71 hits per line