elParaguayo / qtile / 20900155488

83%

Build Type

push

github

Committed by jwijenbergh

Commit Message

Don't finalise widgets twice

`Qtile._finalize_configurables` finalises every widget in `widgets_map`.
It then finalises every `Bar` and `Gap` instance. `Bar.finalize` will
try to finalize every widget in the bar. This can result in log noise
where widgets have subscribed to hooks and tries to unsubscribe having
already unsubscribed.

Widgets have a `finalized` flag so let's just check the widget hasn't
been finalised before calling `finalize()`.

Fixes #5753

Run Details

4 of 4 new or added lines in 2 files covered. (100.0%)

7 existing lines in 4 files now uncovered.

16756 of 20540 relevant lines covered (81.58%)

4.44 hits per line