bjmorgan / py-sc-fermi / 20894109605

95%

main: 95%

Build Type

push

github

Committed by bjmorgan

Commit Message

Simplify overflow handling to suppress rather than warn (#50)

Changed handling of overflow warnings on the basis that
these do not provide actionable information.
If the results are reasonable, ignore the warning; if not,
the problem is self-evident without the warning.

Replaced custom warning classes and deduplication logic with a simple
decorator that suppresses numpy overflow locally in functions where
it's expected (carrier_concentrations, get_concentration).

This fixes the original bug (global warning suppression) by not
touching the warnings system at all.

Run Details

30 of 34 new or added lines in 4 files covered. (88.24%)

1 existing line in 1 file now uncovered.

527 of 556 relevant lines covered (94.78%)

5.64 hits per line