albertms10 / music_notes / 20878410842

100%

push

github

feat(pitch): ✨ add MusicXML notation system parser and formatter (#642)

* feat(pitch): ✨ add MusicXML notation system parser and formatter

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

* test(pitch): 🧪 add test cases for missing exceptions

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

* refactor(pitch): ♻️ migrate to `NoteName` convention

* refactor(pitch): ♻️ simplify variable declaration

* refactor(xml_notation_system): ♻️ extract common responsibilities from `MusicXMLPitchNotation`

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

* refactor(xml_notation_system): ♻️ rename consistent `Xml` symbols

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

* refactor(xml_notation_system): ♻️ rename `V` type parameter

* refactor(pitch): ♻️ extract element names into static constants

---------

Signed-off-by: Albert Mañosa <26429103+albertms10@users.noreply.github.com>

26 of 26 new or added lines in 2 files covered. (100.0%)

1759 of 1759 relevant lines covered (100.0%)

1.94 hits per line