openbraininstitute / neurodamus / 20853175759

90%

Build Type

push

github

Committed by web-flow

Commit Message

`SonataConfig.parsedReports` rework (#463)

## Context

Fix: #457

## Scope

- remove validator in Node. Libsonata does the hard lifting. No need to
do it again. We leave the checks about start and end time down the line
(check report parameters) as consistency is not checked in libsonata
- we still need `ReportParameters` since some variables (start and end
time) can change based on simulator time and cli
- use original libsonata enums throughout the code. No need to reinvent
them. `ReportType, Compartment, Sections, Scaling` local enums have been
removed because of this
- no translation in sonata config. We just collect to dict. Why is it
not a dict in libsonata?
- add registration method like in the rest of neurodamus and
`ReportManager`
- adapt of parsing of `report_on`
- remove test on report parsing as there is no parsing of libsonata
config. Everything is used directly

## Tests
Everything was already tested before

Run Details

54 of 55 new or added lines in 7 files covered. (98.18%)

5 existing lines in 3 files now uncovered.

7332 of 8111 relevant lines covered (90.4%)

2.3 hits per line