Alan-Jowett / CoPilot-For-Consensus / 20828140385

77%

push

github

Make file_path optional in archive schemas for storage-agnostic backends (#790)

* Initial plan

* Make file_path optional in archive schemas and events

- Remove file_path from required fields in archives.schema.json
- Remove file_path from required fields in v1/archives.schema.json
- Make file_path optional in ArchiveIngested event schema
- Make file_path optional in ParsingFailed event schema
- Update schema descriptions to explain storage-agnostic usage
- Update parsing service to use archive:// placeholder for missing file_path

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add tests for storage-agnostic file_path behavior

- Add test_storage_agnostic.py for parsing service
- Add test to verify ArchiveIngested events don't include file_path
- Tests validate optional file_path handling in events and processing

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Add documentation for storage-agnostic archive handling

- Document optional file_path behavior and rationale
- Explain archive location representation per backend
- Detail service implementation changes
- Provide migration path and best practices

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix linting issues in service and test files

- Fix whitespace issues in ingestion and parsing services
- Fix line length violations
- Fix docstring whitespace issues
- Auto-fix test file linting

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Fix parsing service to use None for file_path in error cases

- Use None instead of temp_file_path for storage-agnostic consistency
- Temporary file path is an internal implementation detail
- Ensures archive:// URI placeholder is used in ParsingFailed events

Co-authored-by: Alan-Jowett <20480683+Alan-Jowett@users.noreply.github.com>

* Address code review feedback - improve comments and formatting

- Clarify archive:// URI placeholder d... (continued)

6 of 6 new or added lines in 2 files covered. (100.0%)

6285 of 8186 relevant lines covered (76.78%)

0.86 hits per line