stacklok / toolhive-studio / 20826003728

53%

push

github

fix(remote-mcp): sync the secret key and value for remote mcp (#1440)

* feat(remote-mcp): add editable client secret name field with MCP name prefix

* fix(remote-mcp): simplify grid layout to match actual column count

* docs(remote-mcp): improve client secret name tooltip text

* fix(remote-mcp): sanitize client secret name by replacing hyphens with underscores

* refactor(remote-mcp): extract client secret value builder and type guards

* fix: use prefilled secret key name instead of value for remote MCP

- Fix prepareCreateWorkloadData to use client_secret.name (prefilled key)
  instead of client_secret.value.secret (the actual secret value)
- Add newlyCreatedSecrets param to prepareCreateWorkloadData for
  handling naming collisions (same pattern as update)
- Disable secret key input field (auto-generated, not user-editable)
- Pass newlyCreatedSecrets from handleSecrets to create/update functions
- Add test for naming collision scenario in use-update-server
- Refactor prepareUpdateRemoteWorkloadData to centralize secret name logic

* feat: update secret key name dynamically based on user action

- When selecting a secret from store: show the selected secret name
- When typing a new value: reset to default name (OAUTH_CLIENT_SECRET_{MCP_NAME})
- Extract getDefaultSecretName helper function for reuse
- Add test for secret key name reset behavior
- Update registry MCP test to reflect new behavior

* fix: enable and fix 'updates an existing remote server' test

- Change mock from PATCH to POST /api/v1beta/workloads/:name/edit
- Add mock for GET /api/v1beta/discovery/clients endpoint
- Remove unused PATCH handler from beforeEach
- Update assertion to check POST request to /edit endpoint

2036 of 4168 branches covered (48.85%)

Branch coverage included in aggregate %.

24 of 24 new or added lines in 4 files covered. (100.0%)

3230 of 6075 relevant lines covered (53.17%)

117.62 hits per line