hicommonwealth / commonwealth / 20825777357

38%

push

github

Add Markets App Page (#13238)

* first draft

* second pass

* Subscribe to markets

* Add Markets App Page

* updated markets display

* feat: add FLAG_MARKETS feature flag for prediction markets visibility

Completed GitHub issue #13265
- Added feature flag control for prediction markets UI visibility
- Updated governance_section.tsx to check markets flag for Markets menu item
- Updated AdminSection.tsx to check markets flag for Market Integrations menu
- Added FLAG_MARKETS documentation to .env.example with default value false

Files affected:
- packages/commonwealth/client/scripts/views/components/sidebar/governance_section.tsx
- packages/commonwealth/client/scripts/views/components/sidebar/AdminSection/AdminSection.tsx
- .env.example
- .ai/progress.txt

Tests: Pre-existing type/lint errors unrelated to this change. Manual verification required with FLAG_MARKETS=true/false.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* docs: update progress.txt with commit hash for issue #13265

* fix: resolve React Hooks error by converting Router to a component

Fixed "Rendered more hooks than during the previous render" error by:
- Converting Router from a function returning a router config to a React component
- Router now returns <RouterProvider> directly instead of just the router object
- Updated App.tsx to use <Router /> as a component instead of router()
- Moved useFlag('markets') hook to Router component where it's properly called
- Passed marketsEnabled as parameter to CommonDomainRoutes/CustomDomainRoutes

This ensures hooks are called at the top level of a React component, following
the Rules of Hooks and preventing the conditional hook call issue.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>

* docs: update progress.txt with React Hooks fix details

* feat: add backend validation for FLAG_MARKET... (continued)

2051 of 5853 branches covered (35.04%)

Branch coverage included in aggregate %.

3 of 6 new or added lines in 3 files covered. (50.0%)

3602 of 9120 relevant lines covered (39.5%)

47.02 hits per line