stacklok / toolhive / 20824141899

50%

Build Type

push

github

Committed by web-flow

Commit Message

Add X-Forwarded-Prefix support for SSE endpoint URL rewriting (#3210)

* Add X-Forwarded-Prefix support for SSE endpoint URL rewriting

Implement SSE endpoint URL rewriting in the TransparentProxy to support
path-based ingress routing that strips path prefixes.

Changes:
- Add endpointPrefix and trustProxyHeaders fields to TransparentProxy
- Add sseRewriteConfig type for holding rewrite configuration
- Add getSSERewriteConfig() to determine rewrite config with priority:
  1. Explicit endpointPrefix (highest priority)
  2. X-Forwarded-Prefix header (when trustProxyHeaders is true)
  3. No rewriting (default)
- Add rewriteEndpointURL() to handle both relative and absolute URLs
- Refactor SSE response processing with sseLineProcessor struct
- Only rewrite "event: endpoint" events, pass others unchanged
- Preserve existing session ID extraction functionality

Fixes #3071

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add EndpointPrefix to transport and runner config structs

Wire the endpointPrefix configuration through the transport layer:
- Add EndpointPrefix to transport.Config struct
- Add EndpointPrefix to runner.RunConfig struct
- Update HTTPTransport to accept and pass endpointPrefix to proxy
- Update factory.go to pass EndpointPrefix from config
- Update runner.go to include EndpointPrefix in transport config

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* Add --endpoint-prefix CLI flag to thv run command

Add CLI support for specifying the SSE endpoint URL prefix:
- Add EndpointPrefix field to RunFlags struct
- Add --endpoint-prefix flag with help text
- Add validation to ensure prefix starts with '/' when provided
- Add WithEndpointPrefix builder option in config_builder.go

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

*... (continued)

Run Details

159 of 206 new or added lines in 11 files covered. (77.18%)

2 existing lines in 1 file now uncovered.

29020 of 57953 relevant lines covered (50.08%)

58.51 hits per line