babelfish-for-postgresql / babelfish_extensions / 20810200999

77%

Build Type

push

github

Committed by web-flow

Commit Message

Handling valid characters in  string to money conversion (#4342)

In Babelfish, the logic implemented for casting string to money added stricter validation for invalid characters. This change affecting certain cases in ISNUMERIC()and inadvertently led to rejecting some characters that TSQL allows, such as:

    Backslash () - CHAR(92)
    Comma (,) - CHAR(44)
    Non-breaking space - CHAR(160)

This PR fixes the regression by modifying the money parsing logic to skip these characters, matching T-SQL behavior.

Task: BABEL-6270

Signed-off-by: Vineetha125 <bvineets@amazon.com>

Run Details

37 of 41 new or added lines in 1 file covered. (90.24%)

3 existing lines in 2 files now uncovered.

52595 of 68409 relevant lines covered (76.88%)

392212.78 hits per line