pantsbuild / pants / 20809116480

push

github

make `shell_command` targets be runnable via the `run` goal (#22981)

Teach the shell backend how to run `shell_command` targets via the `run`
goal and make them valid "runnable" targets for other Pants targets
which can reference runnables including `code_quality_tool`. Running a
`shell_command` target can take place in the Pants execution sandbox.

This PR intentionally does not remove nor deprecate `run_shell_command`
and its more limited execution model of only supporting interactive
execution. `run_shell_command` does not have all the fields of
`shell_command` and adding such support seemed a less desirable UX
change than just making `shell_command` be runnable. At the very, this
PR is an incremental improvement over the existing situation and defers
needing to make decision on `run_shell_command` (and the other
`FOO_shell_command` target types) at this time.

44 of 66 new or added lines in 3 files covered. (66.67%)

78793 of 98153 relevant lines covered (80.28%)

3.36 hits per line