stacklok / toolhive / 20798657282

50%

Build Type

push

github

Committed by web-flow

Commit Message

Vmcp: Add but do not use app config to the CRD  (#3203)

This PR adds the vmcpconfig.Config to the VirtualMCPServerSpec, but does not use it. This sets up subsequent work to migrate the existing functionality (e.g. defaults, validation, discovery) built up around the other VirtualMCPServerSpec fields onto their equivalent fields in vmcpconfig.Config.

Supports #3125

Large PR Justification
This PR is large in lines-of-code, but is conceptually small. This PR contains the minimal changes to add config.Config to the VirtualMCPServerSpec.

All changes are motivated by errors from task operator-generate && task operator-manifests && task lint.

Changes
Migrate from any to a CRD-compatible json.Map or json.Any.
The CRD code generation does not support any types in the app config object. The simplest thing to do would be replace all uses with runtime.RawExtension. However, that makes the code that previously depended on map[string]any less typesafe and more verbose, since it must unmarshall the raw contents manually. Consequently, I introduced a pkg/json/any.go that is simpler to work with. Specifically, the json.Map is a typesafe and CRD-compatible map[string]any.

Many test files were updated to use this new type rather than map[string]any.

Use string rather than float for SamplingRate
This one is straightforward. Sampling rate was previously a float which is unsupported by kubebuilder. This also required regenerating the swagger docs.

Generate DeepCopy methods
Kubebuilder requires the config types have DeepCopy methods. Changes to the taskfile and existing config objects ensures this code is generated.

---------

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Run Details

48 of 668 new or added lines in 14 files covered. (7.19%)

2 existing lines in 1 file now uncovered.

28914 of 57773 relevant lines covered (50.05%)

58.69 hits per line