babelfish-for-postgresql / babelfish_extensions / 20783766438

77%

push

github

Fixing typmod for MIN()/MAX() on CHAR/NCHAR datatypes  (#4372)

Earlier in Babelfish, we were losing out on typmod information in case of MIN/MAX() function having CHAR/NCHAR as argument, which was leading to error and requiring explicit casting to Varchar/Nvarchar.

With this commit, we are using pltsql_post_transform_expr_recurse function to detect MIN/MAX aggregates on CHAR/NCHAR types and preserve the original column's typmod by adding a relabel node with the correct type modifier.

Task: BABEL-5688

Signed-off-by: Tanya Gupta tanyagp@amazon.com

20 of 20 new or added lines in 1 file covered. (100.0%)

52575 of 68382 relevant lines covered (76.88%)

386605.32 hits per line