stacklok / toolhive / 20777218544

50%

Build Type

push

github

Committed by web-flow

Commit Message

Allow edit operation to reuse proxy port of the old proxy (#3200)

Prior to this PR, the edit API endpoint would not allow the proxy port
to be reused. This was because the run config validation happened before
stopping the old instance of the workload, and thus the port appeared to
be still in use.

This PR adds some tweaks to the validation logic to allow port reuse for
the edit case. It also tweaks the edit endpoint to reuse the previous
port of the workload if a proxy port is not specified - this feels like
a more natural behaviour than picking a new random port. This
implementation also allows a new port to be selected if the caller
desires.

There is a potential race condition in this implementation: if a new
workload is created between the termination of the previous proxy
process and the creation of the new one, it could potentially "steal"
the port and cause the edit to fail after validation has completed. I
think this is an acceptable risk for now - fixing it will require us to
build some kind of locking mechanism for ports.

Run Details

29 of 29 new or added lines in 4 files covered. (100.0%)

4 existing lines in 1 file now uncovered.

28728 of 56881 relevant lines covered (50.51%)

59.06 hits per line