babelfish-for-postgresql / babelfish_extensions / 20775984408

76%

BABEL_6_X_DEV: 78%

Build Type

push

github

Committed by web-flow

Commit Message

Fixing typmod for MIN()/MAX() on CHAR/NCHAR datatypes (#4377)

Earlier in Babelfish, we were losing out on typmod information in case of MIN/MAX() function having CHAR/NCHAR as argument, which was leading to error and requiring explicit casting to Varchar/Nvarchar.

With this commit, we are using pltsql_post_transform_expr_recurse function to detect MIN/MAX aggregates on CHAR/NCHAR types and preserve the original column's typmod by adding a relabel node with the correct type modifier.

Task: BABEL-5688

Cherry-pick from PR: #4372

Signed-off-by: Tanya Gupta tanyagp@amazon.com

Coverage Stats

20 of 0 new or added lines in 0 files covered. (NaN%)

3 existing lines in 1 file now uncovered.

50522 of 66285 relevant lines covered (76.22%)

395904.01 hits per line