Teamwork / utils / 20765701900

77%

master: 77%

Build Type

Pull #89

github

Committed by rafaeljusto

Commit Message

Fix request body handling in DoExponentialBackoff

Previously, DoExponentialBackoff relied on Seek to reset request bodies
between retries. This approach failed when bodies didn't implement Seek
or when req.GetBody wasn't set (e.g., manually wrapped io.NopCloser),
causing "ContentLength=N with Body length 0" errors on retry attempts.

The issue occurred because req.Clone() reuses the exhausted body reader
without resetting it, leading to empty bodies on subsequent attempts
while ContentLength remained set from the original request.

Now read the entire request body upfront and create fresh io.Readers
for each retry attempt. This ensures:
- Body is always available for all retry attempts
- ContentLength is correctly set to match the actual body
- Works reliably with all io.Reader types, not just seekable ones

Added test case with io.NopCloser-wrapped bytes.Buffer that validates
both body content and ContentLength matching across retry attempts.

Pull Request Pull Request #89: Fix request body handling in DoExponentialBackoff

Run Details

13 of 17 new or added lines in 1 file covered. (76.47%)

5 existing lines in 1 file now uncovered.

1270 of 1646 relevant lines covered (77.16%)

40.67 hits per line