contributte / datagrid / 20755036761

49%

push

github

Fix URL parameter handling for filtering and perPage changes (issue #1208) (#1236)

Fixes issue #1208 where URL refreshing stopped working when using filtering
or changing items per page. Only pagination via buttons was working.

The problem was that the filterSucceeded() method was adding ALL form filter
values to the persistent $filter parameter, including empty ones. This caused
URLs to include empty filter parameters like ?grid-filter[name]=, matching the
reported regression from version 6.x.

Changes:
- Only non-empty filter values are now added to the persistent $filter parameter
- Empty filter values are explicitly unset from $filter
- The $hasNonEmptyFilter flag is now used to determine if filters are active,
  instead of just checking if values exist
- Empty filter values remain stored in session storage for recall, but don't
  appear in URL parameters

This ensures clean URLs and maintains feature parity with version 6.x.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>

7 of 7 new or added lines in 1 file covered. (100.0%)

1327 of 2724 relevant lines covered (48.72%)

0.49 hits per line