PyThaiNLP / pythainlp / 20750414203

53%

Build Type

push

github

Committed by web-flow

Commit Message

Fix check_marttra() Thai final consonant classification (#1173)

* Initial plan

* Fix check_marttra function to handle Thai final consonants correctly

- Fixed handle_karun_sound_silence to correctly remove only silent consonants marked by ์
- Fixed handling of ำ at the end to return กม (not กา)
- Fixed handling of consonant clusters with ร (e.g., กร, ขร, คร) in compound words
- Fixed handling of words with ไ/ใ vowels to distinguish true final consonants ย/ล from vowel components
- Fixed typo in consonant list (", ณ" -> "ณ")
- Uncommented all previously failing test cases

Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>

* Address code review feedback

- Remove duplicate ล from กน consonant list (already classified as เกย on line 282)
- Use imported thai_consonants constant instead of duplicating the string
- Improves code maintainability and eliminates redundancy

Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>

* Optimize helper function by moving to class method

- Moved has_true_final_yl from inline function to class method _has_true_final_yl
- Avoids recreating function object on every check_marttra call
- Improves performance and code organization

Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: wannaphong <8536487+wannaphong@users.noreply.github.com>

Run Details

22 of 23 new or added lines in 1 file covered. (95.65%)

1 existing line in 1 file now uncovered.

4209 of 7957 relevant lines covered (52.9%)

0.53 hits per line