kubernetes-sigs / kubebuilder / 20748818898

73%

push

github

🐛 (helm/v2-alpha): Add nameOverride/fullnameOverride support and fix cert-manager templating (#5294)

Adds standard Helm naming support (nameOverride/fullnameOverride)
to the Helm v2-alpha plugin and implements dynamic resource name truncation
to ensure Kubernetes 63-character compliance while maintaining cross-resource
reference consistency.

Key changes:

1. Add nameOverride/fullnameOverride to values.yaml following Helm best practices
2. Simplify _helpers.tpl to match official Helm chart starter templates
3. Implement dynamic truncation: maxLen = 62 - len(suffix) (replaces hardcoded 45-char limit)
4. Fix cert-manager resource templating (Issuer names, issuerRef, annotations)
5. Add generic regex-based name substitution for all resource types
6. Update app.kubernetes.io/name label to use chart.name template

This ensures all generated Helm charts:
- Support custom naming via standard Helm values
- Respect Kubernetes 63-character name limits
- Maintain cross-resource reference consistency (Service ↔ Certificate ↔ Webhook ↔ Issuer)
- Work correctly with cert-manager (no more stuck certificates or failed issuance)
- Follow Helm and Kubernetes best practices

Assisted-by: CLAUDE

76 of 89 new or added lines in 6 files covered. (85.39%)

6234 of 8730 relevant lines covered (71.41%)

30.23 hits per line