stacklok / toolhive / 20729476581

50%

Build Type

push

github

Committed by web-flow

Commit Message

VMCP: Delete rawConfig (#3155)

Deleted rawConfig and unmarshal directly to config.Config with strict mode.

Step 1 of #3125

Changes to pkg/vmcp/config/yaml_loader.go:
Removed all raw types :

rawConfig, rawIncomingAuth, rawOutgoingAuth, rawBackendAuthStrategy
rawHeaderInjectionAuth, rawTokenExchangeAuth, rawAggregation
rawConflictResolutionConfig, rawWorkloadToolConfig, rawToolOverride
rawCompositeTool, rawWorkflowStep, rawStepErrorHandling
rawElicitationResponse, rawOutputConfig, rawOutputProperty
Rewrote Load() to use strict unmarshalling:

decoder := yaml.NewDecoder(bytes.NewReader(data))
decoder.KnownFields(true) // Reject unknown fields
if err := decoder.Decode(&cfg); err != nil { ... }
Replaced transform* methods with process* post-processing:

processOutgoingAuth() - resolves environment variables
processBackendAuthStrategy() - validates and resolves env vars for auth strategies
processCompositeTool() - validates JSON Schema parameters
processWorkflowStep() - applies type inference and default timeouts
Changes to pkg/vmcp/config/config.go:
Added yaml: tags to all struct fields that were missing them (to support yaml.v3 strict mode):

CompositeToolConfig fields
WorkflowStepConfig fields
StepErrorHandling fields
ElicitationResponseConfig fields
AggregationConfig.ExcludeAllTools
WorkloadToolConfig.ExcludeAll
Test updates:
Updated test files to work with the new direct unmarshalling approach:

yaml_loader_transform_test.go - tests process* methods
crd_cli_roundtrip_test.go - tests direct marshal/unmarshal roundtrips
---------

Signed-off-by: Jeremy Drouillard <jeremy@stacklok.com>

Run Details

59 of 63 new or added lines in 3 files covered. (93.65%)

28 existing lines in 4 files now uncovered.

28661 of 56819 relevant lines covered (50.44%)

59.53 hits per line