dcdpr / jp / 20715320592

58%

push

github

enhance(cli, attachment): improve relative path handling (#366)

File attachments now benefit from better workspace awareness and
validation. When adding or removing attachments via the CLI, relative
paths are resolved against the current working directory and then
validated to ensure they reside within the workspace root.

For example, if the workspace root is `/foo` and the current working
directory is `/foo/bar`, then `../baz.txt` will be resolved as
`/foo/baz.txt`, which is inside the workspace, but `../../baz.txt` will
be resolved as `/baz.txt`, which is outside the workspace, and returns
an error. Absolute paths are allowed, as long as they point to a file or
directory within the workspace.

This restriction exists because attachments are lazy-loaded, and we want
to ensure workspace conversations can be used across multiple machines
or users.

To facilitate this change, CLI attachment argument parsing is split into
two phases: an argument parser that distinguishes between URLs and file
paths, using the new `AttachmentUrlOrPath` enum, and at a later stage,
when we have access to the workspace root path, we validate and rewrite
the attachment path relative to the workspace root.

Additionally, the `path-clean` dependency has been replaced with
`clean-path` for an unsafe-free alternative.

Example usage with relative paths:

```shell
jp query --attachment ../lib.rs "Explain this file"
jp query -a /path/to/workspace/README.md "Explain this project"
```

---------

Signed-off-by: Jean Mertz <git@jeanmertz.com>

14 of 80 new or added lines in 8 files covered. (17.5%)

9125 of 18276 relevant lines covered (49.93%)

125.83 hits per line